Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove limit on Taxon tree relationships by rank #2364

Closed
grantfitzsimmons opened this issue Oct 28, 2022 · 3 comments
Closed

Remove limit on Taxon tree relationships by rank #2364

grantfitzsimmons opened this issue Oct 28, 2022 · 3 comments
Assignees
Labels
1 - Request Improvements or extensions to existing behavior 2 - Trees Issues that are related to the tree system and related functionalities.

Comments

@grantfitzsimmons
Copy link
Member

Currently in Specify 7 and 6 you are restricted to only seeing the taxon full name and author for each rank. This restriction causes issues when it comes to running a query from the collection object or creating reports and labels where you want to reference a specific field for a specific rank.

In this case, I am reworking the University of Washington's labels to reference the family number, stored in a text field at the family level.

There is no way to reference this number without using relationships through the "Parent Taxon" several times and hoping that the parent is the family. For their database, all specimen records are determined to species at the moment, but this is going to change in the future and the flexibility is necessary. I have to stack parent relationships to ensure that it will not be missed.

@grantfitzsimmons grantfitzsimmons added 1 - Request Improvements or extensions to existing behavior pri:unknown labels Oct 28, 2022
@maxpatiiuk maxpatiiuk added this to Unsorted in Trees via automation Dec 6, 2022
@maxpatiiuk
Copy link
Member

From what I remember Ben told me, this restriction was put in place artificially just to match the limitations of specify 6 (yeah, this is from the dark dark days where sp7 was limited just to not outcompete specify 6)

Here is the code for that:

TAXON_FIELD_RE = re.compile(r'(.*) ((Author)|(GroupNumber))$')
# Look to see if we are dealing with a tree node ID.
TREE_ID_FIELD_RE = re.compile(r'(.*) (ID)$')
(it currently allows only Author, ID and Group Number fields - and full name implicitly if field name was not provided). Modifying that code and lifting the restriction on the front-end should fix this

@grantfitzsimmons
Copy link
Member Author

Let's remove that code...

@grantfitzsimmons
Copy link
Member Author

Closing in favor of #4697

@grantfitzsimmons grantfitzsimmons closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2024
Trees automation moved this from Unsorted to Shipped Mar 28, 2024
@grantfitzsimmons grantfitzsimmons removed this from Shipped in Trees Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Request Improvements or extensions to existing behavior 2 - Trees Issues that are related to the tree system and related functionalities.
Projects
None yet
Development

No branches or pull requests

5 participants