Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synonymized nodes are not counted in the tree #3724

Open
grantfitzsimmons opened this issue Jul 5, 2023 · 5 comments
Open

Synonymized nodes are not counted in the tree #3724

grantfitzsimmons opened this issue Jul 5, 2023 · 5 comments
Labels
1 - Bug Incorrect behavior of the product 2 - Trees Issues that are related to the tree system and related functionalities. todo:discuss Needs Discussion
Projects

Comments

@grantfitzsimmons
Copy link
Contributor

Synonymized terms are not counted. In the tree, next to each term "(0)" records are always displayed, despite the fact that they have been used as a determination for a collection object. If these synonyms are children of a preferred term, the indirect records of the parent are not counted.

image

Records can be obtained, however, from the query that is generated directly (button at the top of the tree).

Reported By: Jordi at MCNB (Trello)

@grantfitzsimmons grantfitzsimmons added 1 - Bug Incorrect behavior of the product todo:discuss Needs Discussion 2 - Trees Issues that are related to the tree system and related functionalities. labels Jul 5, 2023
@grantfitzsimmons grantfitzsimmons added this to Unsorted in Trees via automation Jul 5, 2023
@realVinayak
Copy link
Collaborator

realVinayak commented Jul 6, 2023

This discrepancy is because counts use preferred taxon and the 'Query' button uses taxon (and not preferred taxon). Not sure if that's a bug or a design decision. In this case, probably what happened it the nodes were synomized later. The preferred taxon of determination was changed (as it should have been) to point to the new taxa, but since taxon id of determination remained same, the 'Query' still gets the rows before synomize action, but the tree count won't count these (as it looks at preferred taxon).

"If these synonyms are children of a preferred term, the indirect records of the parent are not counted." Do we really want any synomized node to instead get counts from the accepted node? I don't think it would have enough value to the user. For example, if every species is synomized to a genus in a particular branch, then after implementing this, all the species in that branch would have the exact same count (which would be of determinations directly assigned to genus, and to every other species in that subtree). Not sure if that'd be of any useful value to the user.

instead, it might make more sense to just report determinations through taxon id in case a node is not accepted (which is what 'Query' does). This would then represent the count of determinations which were previously assigned to this node before it got synomized to anything else. This might confuse the users though because the count will have different meaning depending on whether node is accepted or not.

@grantfitzsimmons
Copy link
Contributor Author

This was brought up again today on Trello:

If we have correctly interpreted how the number of records associated with each taxon should be shown in the tree, we think that this example should be displayed as follows:

image

I think the tree behavior is what we should expect when the query is run. I don't think the synonyms should not be counted as you mentioned.

The query button should run the same query (so it should use Preferred Taxon instead of Taxon. This is just a bug in my opinion that has to do with the query being constructed incorrectly when the "query" button is clicked.

Let's discuss this with them and others to hear their fedback!

@grantfitzsimmons
Copy link
Contributor Author

grantfitzsimmons commented Feb 15, 2024

RBGE says it would be useful to show the synonym counts to find the filing location.

Looks like it should be a preference.

@grantfitzsimmons
Copy link
Contributor Author

This is exactly what you mentioned at the end. It would be logical for the number shown in the tree to match the search results using the query button magnifying glass. We believe that the number should show how many CollectionObjects use the valid term (isCurrent=True). Our museum's collection database dates back to 1800, and pieces are often requested by their original name. Therefore, the history of determinations and synonyms can be long.

Jordi on Trello

@specifysoftware
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product 2 - Trees Issues that are related to the tree system and related functionalities. todo:discuss Needs Discussion
Projects
Trees
  
Unsorted
Development

No branches or pull requests

3 participants