Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Loan Preparations does not show "add items" dialog in default forms #4078

Closed
grantfitzsimmons opened this issue Oct 6, 2023 · 3 comments · Fixed by #4533
Closed
Assignees
Labels
1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more 2 - User Interface Issues that are related to the user interface or user experience.
Milestone

Comments

@grantfitzsimmons
Copy link
Member

grantfitzsimmons commented Oct 6, 2023

When using the default Loan form (defined in the common.views.xml file), it renders the Loan Preparations in a "table" view rather than a grid. When in this view, the add button does not show the 'add items' dialog that shows when the type is not specified.


Form definition that does offer the ability to add preps from a record set or list of identifiers:

Screen.Recording.2023-10-06.at.11.37.30.AM.mov
                <row>
                     <cell type="subview" viewname="LoanItems" id="LoanItems" name="loanPreparations" defaulttype="table" colspan="15" rows="4"/>
                </row>

Form definition that does not offer the ability to add preps from a record set or list of identifiers:

https://github.com/specify/specify6/blob/945d28f00288d2d64979848fb2fb63fda34bdd1b/config/common/common.views.xml#L5712C17-L5714

Screen.Recording.2023-10-06.at.11.36.29.AM.mov
                <row>
                    <cell type="subview" viewname="LoanItems" id="10" name="loanPreparations" colspan="17" rows="4"/>
                </row>

v7.9.1-prerelease and v7.9.0
Arc browser, macOS Sonoma

Reported By: @bronwyncombs

@grantfitzsimmons grantfitzsimmons added 1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more 2 - User Interface Issues that are related to the user interface or user experience. labels Oct 6, 2023
@CarolineDenis
Copy link
Contributor

@grantfitzsimmons or @bronwyncombs, would you have the name of a db and collection that you know has the pop up dialog when clicking on + to add loan preparation?

@grantfitzsimmons
Copy link
Member Author

grantfitzsimmons commented Jan 12, 2024

@grantfitzsimmons or @bronwyncombs, would you have the name of a db and collection that you know has the pop up dialog when clicking on + to add loan preparation?

You just need to change the definition to look like this in any database:

                <row>
                     <cell type="subview" viewname="LoanItems" id="LoanItems" name="loanPreparations" defaulttype="table" colspan="15" rows="4"/>
                </row>

@grantfitzsimmons
Copy link
Member Author

This was encountered and reported by The University of Michigan today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more 2 - User Interface Issues that are related to the user interface or user experience.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants