Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out authentication strategy for visual #13

Closed
AlanRynne opened this issue Dec 6, 2022 · 4 comments
Closed

Figure out authentication strategy for visual #13

AlanRynne opened this issue Dec 6, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@AlanRynne
Copy link
Member

From #10 and #11

Viewer cannot fetch data from private streams due to it lacking access to the Data Connector token.

Not sure if this is something that can be provided, or if we're going to have to re-invent the wheel on this one.

Possible options:

  • Have the Data Connector pass the token to the Visual (not sure if it is doable)
  • Have the visual receive the actual objects from the data connector instead of fetching them
@AlanRynne AlanRynne added the bug Something isn't working label Dec 6, 2022
@AlanRynne AlanRynne self-assigned this Dec 6, 2022
@AlanRynne AlanRynne added this to the 2.11 milestone Dec 6, 2022
@AlanRynne
Copy link
Member Author

Passing the data to the token is not a viable alternative. I've had chat with Alex about option 2, which is not going to be immediately doable.

@AlanRynne AlanRynne modified the milestones: 2.11, 2.x Jan 4, 2023
@AlanRynne AlanRynne added enhancement New feature or request and removed bug Something isn't working labels May 18, 2023
@AlanRynne
Copy link
Member Author

AlanRynne commented May 19, 2023

After fixing #30 we can enable the viewer to do OAuth on it's own.

Just let Vue handle the entire auth logic as we've done in plenty other apps. We already have a powerbi app so there is no server-side blocker for this, unless we want to have a separate app for metrics purposes.

@AlanRynne
Copy link
Member Author

This is now unblocked :D

@bimgeek
Copy link
Contributor

bimgeek commented Dec 15, 2023

Closing this ticket as we are moving to Jira to reduce noise. You can access it there.

@bimgeek bimgeek closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants