Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Revise the async mechanisms #1049

Closed
cristi8 opened this issue Feb 22, 2022 · 1 comment · Fixed by #1165
Closed

Core: Revise the async mechanisms #1049

cristi8 opened this issue Feb 22, 2022 · 1 comment · Fixed by #1165
Assignees
Labels
core issues related to the .net sdk.

Comments

@cristi8
Copy link
Contributor

cristi8 commented Feb 22, 2022

We have a number of parallel mechanisms in place for faster serialization and server communication.

We should make sure the appropriate async mechanisms is used in each case.

In particular:

This ticket is a result of multiple related issues / questions.

We should also briefly document somewhere the parallelism involved and how it's done.

@cristi8 cristi8 added the core issues related to the .net sdk. label Feb 22, 2022
@cristi8 cristi8 self-assigned this Feb 22, 2022
@cristi8
Copy link
Contributor Author

cristi8 commented Apr 4, 2022

Modified a few .Result / .Wait with await, but there are still a few places, like the Transport sync method:

public string GetObject(string id)

Still has to block the calling thread and can deadlock UI calls

So for now, callers of the SDK, especially when calling methods from the UI thread, must call with Task.Run to switch to a background thread for the actual work

@cristi8 cristi8 closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core issues related to the .net sdk.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant