Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH: Some Object components do not support 3rd party GH_Goo<Base> classes #2609

Closed
AlanRynne opened this issue May 29, 2023 · 0 comments · Fixed by #2610
Closed

GH: Some Object components do not support 3rd party GH_Goo<Base> classes #2609

AlanRynne opened this issue May 29, 2023 · 0 comments · Fixed by #2610
Assignees
Labels
bug Something isn't working grasshopper issues related to the grasshopper connector.

Comments

@AlanRynne
Copy link
Member

From the server: https://speckle.community/t/custom-speckle-object-integrating-with-existing-speckle-gh-components/5849/3

Still need to gather some more details here, but the user has identified a miss-alignment with how some object components process the input inside SolveInstance.

All objects should accept any input type, and attempt to:

  • Check if the inner value is Base
  • Check if the inner value could be converted by the selected converter.
  • Return an error if not.

This doesn't seem to be fully the case in the K/V components.

@AlanRynne AlanRynne added bug Something isn't working grasshopper issues related to the grasshopper connector. labels May 29, 2023
@AlanRynne AlanRynne self-assigned this May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working grasshopper issues related to the grasshopper connector.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant