Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align stream state management and update behaviour across connectors #2635

Closed
teocomi opened this issue Jun 2, 2023 · 0 comments
Closed
Labels
acadcivil issues related to Autocad or Civil3D CSI desktopui issues related to the desktop ui. enhancement New feature or request revit issues related to the revit connector. rhino tekla

Comments

@teocomi
Copy link
Member

teocomi commented Jun 2, 2023

The Stream State

Contains information about a "stream card" such as if it's a sender/receiver, selected branch etc. But also information about its previous receive operation, so that we can update elements of future receives.

Our Connectors handle stream state and consequentially the update behavior in different ways.

In Revit, it's stored in the stream cards and then in the Doc's extensible storage.
In Rhino, it's stored in the stream cards and on the object themselves.
In CSI products, it's stored in an external text file as there are no native ways to store custom data on the objects or documents.

The Problem(s)

Because of these different implementations, we have slightly different behaviors across the connectors.
For instance, in Revit the update functionality is entirely dependent on the Stream Card, if this is changed, the update capabilities can break.
If a different branch is selected, and new objects are received, the previously received ones are deleted as the update logic detects completely different IDs.
If the stream card is deleted and re-added, no update capability is preserved as the IDs are lost.

Proposed Solution

To be discussed, but perhaps storing the IDs on the objects themselves where possible, seems to be the most flexible option. In Revit it would require overcoming some potential performance challenges.
A good time to tackle this would be together with DUI3.

@teocomi teocomi added enhancement New feature or request revit issues related to the revit connector. rhino acadcivil issues related to Autocad or Civil3D tekla CSI desktopui issues related to the desktop ui. labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acadcivil issues related to Autocad or Civil3D CSI desktopui issues related to the desktop ui. enhancement New feature or request revit issues related to the revit connector. rhino tekla
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants