Skip to content
This repository has been archived by the owner on May 1, 2019. It is now read-only.

Receiver layer data doesn't update on stream refresh #31

Open
mswaidan opened this issue Mar 30, 2018 · 1 comment
Open

Receiver layer data doesn't update on stream refresh #31

mswaidan opened this issue Mar 30, 2018 · 1 comment

Comments

@mswaidan
Copy link
Collaborator

mswaidan commented Mar 30, 2018

E.g.: Add an object to a stream via grasshopper component. Refresh stream in viewer.

-receiver.objects[] updates to show added object
-receiver.layers.layer.objectCount remains unaffected

I think this is being caused in store.js, but am not certain.

@didimitrie
Copy link
Member

I'm going to try and poke in the viewer as well to update it for the new api 1.0.0-beta which is implemented on the server bracnch patch-endpoints.

Changes relevant to this issue:

  • stream layers are just friggin "grasshopper" layers, simple and no colours and other stuff
  • streams got an extra property called viewerLayers where he can do whatever magic

Flow would be: get new stream > check if viewer layers has some stuff:

  • if yes apply colors, etc
  • if no, generate some viewer layers based on the existing stream layers
  • if mismatch, diff by guid and remove old viewer layers or create new ones

As for the store, i think the flow, etc. can be easier or more clear, at least (see the actions from the admin one). Ideally those api calls would be wrapped away in an independent js module too so it's easier to plug in and out on future updates.

@didimitrie didimitrie added this to the 0.0.5 milestone Mar 30, 2018
@didimitrie didimitrie modified the milestone: 1.0.0-beta May 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants