Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-completion is not working well according to entered phrase #16

Closed
LirazShay opened this issue Mar 19, 2019 · 14 comments
Closed

Auto-completion is not working well according to entered phrase #16

LirazShay opened this issue Mar 19, 2019 · 14 comments
Labels
enhancement New feature or request

Comments

@LirazShay
Copy link

LirazShay commented Mar 19, 2019

I've entered the word 'list' and I see all sentences, including those without the word 'list'

It is very important feature, since steps are globally and the autocompletion is a way to search for matching steps

See attached video
auto-completion.zip

https://streamable.com/xazsl

@LadaVarga
Copy link

Am I doing something wrong as intelisense or autocompletion cannot find anything. I tried clean the solution and rebuild and result is the same I can't see my steps at all. It is not working if I have steps in same solution or If I use external shared steps.

@gasparnagy
Copy link
Contributor

@LirazShay thx. yes, this makes sense, I need to add some filtering logic to it.

@LadaVarga Is the navigation working? (If navigation works that means that Deveroom was able to detect the step definitions.) Also it is important to mention that currently the step completion does not pop up automatically, you have to press Ctrl+Space.

@gasparnagy gasparnagy added the enhancement New feature or request label Mar 20, 2019
@LadaVarga
Copy link

LadaVarga commented Mar 21, 2019

@gasparnagy Navigation is not working with DEVEROOM, I can't navigate to definition in the same solution. App.config is filled correctly I believe:
<specFlow> <!-- For additional details on SpecFlow configuration options see http://go.specflow.org/doc-config --> <stepAssemblies> <stepAssembly assembly="SpecResults" /> <stepAssembly assembly="Core.Automation.AWS" /> <stepAssembly assembly="Core.Automation.Shared" /> <stepAssembly assembly="Core.Automation.SharedSteps" /> </stepAssemblies> <plugins>

Will try update VS 2017 to latest version 15.9.9 and I will let you know. IF there are somehwhere any log for that let me know I can send it here.

@gasparnagy
Copy link
Contributor

@LadaVarga Deverooms saves the log files to the C:\Users\<youruser>\AppData\Local\Deveroom folder. There you will find the logs by date.

@LadaVarga
Copy link

@gasparnagy Looks like deverooms doesn't recognize speflow during discovery. I use Specflow 2.4.0 and VS 2017 the latest one update. I've tried delete specflow files from temp, clean solution and rebuild completely. I can see the colors in the steps but navigation is not possible. One things what we used is we generate feature.cs files by prebuild task (by specflow.exe command), it means we don't need to store feature.cs files in source control.
Deveroom log:
2019-03-21T19:02:36, Verbose, LoadProjectSystem: Loading VsProjectSystem...
2019-03-21T19:02:36, Info, .ctor: Starting Deveroom...
2019-03-21T19:02:36, Info, CreateProjectScope: Initializing project: Core.Automation.Tests
2019-03-21T19:02:37, Info, OnSettingsInitialized: Project settings initialized
2019-03-21T19:02:37, Verbose, .ctor: Creating DeveroomTagger (project: Core.Automation.Tests, SpecFlow: n/a)
2019-03-21T19:02:37, Verbose, SolutionEventListenerOnLoaded: Solution loaded
2019-03-21T19:02:39, Verbose, CheckConfiguration: Checking configuration...
2019-03-21T19:02:39, Verbose, CheckConfiguration: Configuration loaded
2019-03-21T19:02:39, Verbose, GetBindingRegistry: Initial discovery triggered...
2019-03-21T19:02:39, Verbose, RecalculateBindingRegistryInternal: Non-SpecFlow project
2019-03-21T19:02:39, Verbose, Parse: Parsed buffer v1 in 156ms on thread 1
2019-03-21T19:02:49, Verbose, PreExec: Go To Step Definition
2019-03-21T19:02:49, Verbose, PreExec: Go To Step Definition
2019-03-21T19:02:49, Verbose, PreExec: Go To Step Definition

@gasparnagy
Copy link
Contributor

@LadaVarga Are you using SpecFlow through NuGet or binary references?

@LadaVarga
Copy link

LadaVarga commented Mar 21, 2019

@gasparnagy We use Paket + References. Example of reference: C:!!code\core-automation\packages\SpecFlow\lib\net45\TechTalk.SpecFlow.dll

@gasparnagy
Copy link
Contributor

@LadaVarga Does that mean, that you have a packages.config file where the SpecFlow package is listed?

@LadaVarga
Copy link

@gasparnagy No, we use paket.dependecies example:
source http://ourART/artifactory/api/nuget/nuget-3rdParty/
source http://ourART/artifactory/api/nuget/nuget-automation-stable
source http://ourART/artifactory/api/nuget/nugets

nuget SpecFlow == 2.4.0
nuget SpecFlow.CustomPlugin == 2.4.0
nuget SpecFlow.NUnit == 2.4.0
nuget SpecResults == 0.1.0.7
nuget SpecResults.Json == 0.1.0.7
nuget SpecResults.WebApp == 0.1.0.3

and we've addded Specflow via Add reference -> Browse .dll stored usually in packages folder-> Select dll.
2019-03-21 19_43_36-Core Automation - Microsoft Visual Studio
](url)

@gasparnagy
Copy link
Contributor

@LadaVarga I see. This scenario is not supported yet (#14 tracks it). This seems to be important for more people, so I will try to get a solution for this soon. You need to wait a bit. :(

@LadaVarga
Copy link

@gasparnagy NP will wait. Thanks a lot for your cooperation

@gasparnagy
Copy link
Contributor

@LirazShay your original request has been added in v1.2.
(The issue of @LadaVarga is still open, tracked with #14)

@LirazShay
Copy link
Author

@gasparnagy
Sorry, but we need to improve the algorithm of filtering the steps.
When compared to the original extension I found some problems with deveroom:

  1. When I enter 2 words 'bid will', in the original extension it finds me also the step 'the bid list will..' but deveroom doesn't match to this step
  2. Original extension shows much more steps in the autocompletion (see image)
  3. Original extension shows also strings values (see image)
  4. Original extension when I select step with table it also inserts the table whereas in deveroom it doesn't
    image

ezgif com-video-to-gif

Sorry...

@gasparnagy
Copy link
Contributor

@LirazShay thx for the feedback. There are some differences between the models of the two extensions so it is not possible to make it work really the same way (common feedback for the original extension was BTW, that it shows too many items), but points 1) and 4) would definitely be possible and senseful. I will create a separate issue to track those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants