This repository has been archived by the owner on Apr 15, 2021. It is now read-only.
Future fork conditions #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could consider checking the protocol version when a ping message (or even when any message) comes in, and dropping the peer if it doesn't meet the new minimum. That would be equivalent to getting users to restart their wallets, without them actually having to. |
|
To be reviewed and a new method to be tested |
|
as discussed we'll work on a different approach |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coded a chain fork condition based on nTime, which moves the minimum protocol check to a new constant. Suggest once the fork in complete in the future we remove this code and revert back to using the standard MIN_PEER_PROTO_VERSION checks
Also bear in mind this only work when peers connect to the user wallet. If there are already the max amount of peers connected then the wallet wont be listening for any new ones so the check wont be invoked.
Once the fork nTime has passed i sugest telling all users to restart their wallets, Then all new connections will be checked for the new minimum protocol version