Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeRegistrar should be public #1110

Closed
scosec opened this issue Dec 12, 2022 · 6 comments
Closed

TypeRegistrar should be public #1110

scosec opened this issue Dec 12, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@scosec
Copy link

scosec commented Dec 12, 2022

Information

  • .Net Core
  • Version: 6.0

Describe the bug
The typeregistrar should be a public class. If you follow the example from the documentation with dependency injection it doesn't work because the class is internal and can't be used outside the namespace.

To Reproduce
Copy the documentation example with dependency injection.

Expected behavior
Allow usage for the TypeRegistrar

Screenshots
spectre

@scosec scosec added bug Something isn't working needs triage labels Dec 12, 2022
@patriksvensson
Copy link
Contributor

TypeRegistrar should not be made public. It's just used internally if no custom type-registrar is available. We should update the documentation.

@scosec
Copy link
Author

scosec commented Dec 12, 2022

Ah oke, I will create my own then! Thanks for the quick reply!

@nils-a
Copy link
Contributor

nils-a commented Dec 12, 2022

@scosec, if you need a prebuild TypeRegistrar, you can have a look at

@scosec
Copy link
Author

scosec commented Dec 13, 2022

Hi Nils,

Thanks for your reply. Certainly helpfull! :)

And a great project guys. I was building my own task runner and then heard this tool on the dotnet rocks podcast.
Let's say. Sold :)

@scosec scosec closed this as completed Dec 13, 2022
@patriksvensson
Copy link
Contributor

@scosec Thank you! What episode was that if I might ask?

@scosec
Copy link
Author

scosec commented Dec 13, 2022

@patriksvensson they mentioned it in the last episode wolverine.net command and messagebus with jeremy miller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done 🚀
Development

No branches or pull requests

3 participants