Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelpProvider colors should be configurable #1379

Closed
FrankRay78 opened this issue Nov 24, 2023 Discussed in #1357 · 3 comments · Fixed by #1408
Closed

HelpProvider colors should be configurable #1379

FrankRay78 opened this issue Nov 24, 2023 Discussed in #1357 · 3 comments · Fixed by #1408
Assignees
Labels
area-CLI Command-Line Interface
Milestone

Comments

@FrankRay78
Copy link
Contributor

Discussed in #1357

Originally posted by sebbarg November 7, 2023
The colors in the HelpProvider are hardcoded. Showing help on a bright background (e.g. old school default MacOS terminal) becomes really hard to read, primarily because of the yellow colors.

How do I deal with that? I can create a custom help provider, but that seems a bit much just to fix some hardcoded colors.

@FrankRay78 FrankRay78 self-assigned this Nov 24, 2023
@FrankRay78 FrankRay78 added this to the 0.49 milestone Nov 24, 2023
@FrankRay78 FrankRay78 added the area-CLI Command-Line Interface label Nov 24, 2023
@FrankRay78
Copy link
Contributor Author

FYI. I'm actively working on this.

@FrankRay78
Copy link
Contributor Author

The latest check-in on the draft PR, now supports removing all styling from the help text through a configuration setting, namely:

configurator.Settings.IgnoreStyling = true;

At the moment, the default remains false, preserving the current default behaviour to style help text.

@FrankRay78
Copy link
Contributor Author

FYI. I've checked in a PR with the final proposed changes, ready for review. #1408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CLI Command-Line Interface
Projects
Status: Done 🚀
Development

Successfully merging a pull request may close this issue.

1 participant