Fix BAYC compatibility #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpierre
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Thank you for this PR! The issue was with isNftMetadata(), which was a little bit too strict.
I also added a mock function to deal with fetch() in Jest, and I moved the new tests in their own file.
I think this is good to be merged & release, could you confirm that it now works for you before I merge the PR? Thanks! 🙏
|
Yes, this works now. Many thanks! |
bpierre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated utils.test.tsx with 2 Boring Ape NFTs that don't work and 2 NFTs that do work properly.
The error happens in src/fetchers/shared/fetch-metadata.tsx at line 40 - "Invalid data received"
I'm not sure what the cause is, but note that the Boring Ape NFTs don't have "name" or "description" in their metadata. If that is the issue, I believe this would be a simple fix.
Boring Apes:
https://ipfs.io/ipfs/QmeSjSinHpPnmXmspMjwiXyN6zS4E9zccariGR3jxcaWtq/6262
https://boredapeyachtclub.com/api/mutants/26708