Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: switch from brukeropusreader to brukeropus #757

Open
joshduran opened this issue May 8, 2024 · 0 comments
Open

[FEATURE]: switch from brukeropusreader to brukeropus #757

joshduran opened this issue May 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@joshduran
Copy link

joshduran commented May 8, 2024

Is your feature request related to a problem?

brukeropusreader appears to no longer be maintained. In addition, it does not use a complete parsing of the OPUS file directory to extract the various data/param blocks.

Describe the solution you'd like

I recently published an open-source python package for reading Bruker OPUS files. It uses a more complete algorithm for extracting and accurately categorizing the data/param blocks in an OPUS file. Rather than trying to maintain a fork of brukeropusreader yourselves, you might find it useful to adopt my package instead:

https://github.com/joshduran/brukeropus

Describe alternatives you've considered

Instead of a modified dictionary, my package returns a custom OPUSFile class. It has all the same data as the modified dictionary (and more), but obviously uses different syntax for accessing that data. I am considering writing a compatibility function for returning a modified dictionary that mimics the brukeropusreader output. This wouldn't be as full featured as my OPUSFile class, but it would make switching packages more or less trivial to start (change import statement and dependencies). If that is of interest to you, let me know.

Additional context

No response

@joshduran joshduran added the enhancement New feature or request label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant