Skip to content
This repository has been archived by the owner on Mar 24, 2022. It is now read-only.

Support DELTA_ENCODED object w/ base BINARY_OBJID? #16

Closed
lyda opened this issue May 30, 2017 · 7 comments
Closed

Support DELTA_ENCODED object w/ base BINARY_OBJID? #16

lyda opened this issue May 30, 2017 · 7 comments

Comments

@lyda
Copy link

lyda commented May 30, 2017

Your implementation doesn't support object type 0x70 but the the gogits/git repo does.

Their implementation passes in indexfiles but maybe just making readObjectBytes a func (repos *Repository) would solve that? I'm not fully clear on how that part works.

@pgundlach
Copy link
Member

The problem I have is that I can't test this.

@lyda
Copy link
Author

lyda commented May 30, 2017

Ah. OK, I have at least one repo with this problem. I can't now but will post it and the code to exercise it later today.

@lyda
Copy link
Author

lyda commented May 31, 2017

Here's a test program and test repo: https://github.com/lyda/gogit-test

Just cloning the example repo from github didn't work annoyingly.

@lyda
Copy link
Author

lyda commented Jun 5, 2017

Just so it's clear, I put a tarball of a git repo that causes this problem up on dropbox:

https://www.dropbox.com/s/p7smueklddt8bws/highlight.js.git.tar?dl=0

The repo I linked to will pull it down, untar it in a subdir (that's test.sh) and then try and open it (that's repo.go).

@pgundlach
Copy link
Member

I have downloaded the repository, but currently unable to look into it. Give me a few days, please.

@lyda
Copy link
Author

lyda commented Jun 6, 2017

Yep, no worries. I just looked at what I posted and realised I was a little too taciturn in my follow-up post. Thought a better explanation might let you know what was there rather than having to dig around and figure it out. Take your time!

@pgundlach
Copy link
Member

Have to close this, sorry.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants