Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db_test assertion - changing dynamically write buffer size not aligned with pending memtable creation #69

Closed
ayulas opened this issue Jul 26, 2022 · 3 comments

Comments

@ayulas
Copy link
Contributor

ayulas commented Jul 26, 2022

in db test changing dynamically write buffer size and it is not aligned to the fact we have an active memtable and a pending memtable...
so the check of the L0 files (meainng the memtable that have done flush) depending the increase/decrease write buffer size is incorrect cause the pending memtable is created with the previous write buffer size ...

@ayulas
Copy link
Contributor Author

ayulas commented Jul 27, 2022

Found a way to fix it. i tested and it was solved.
i will transfer for review

the fix is in the code.... not in the test.
when i create the pending memtable i dont activate it with allocator resources that cause the issue (part of the flush threshold but it shouldn't , cause it doent in the game yet) when it turns active i set the current cf values to the activate memtable so if the write buffer size was changed after the pending memtable was created , it will get the correct value as part of activation and the test will get what it want.

note that the memtable object creation is not part of the flush threshold - the bucket shouldnt be calculate as a write buffer. so it doesnt use the arena. (it is like that today - just mention it to explain that its ok to set the arena parameters after the memtable was created but wasnt activated yet)

@isaac-io
Copy link
Contributor

Found in #14 (comment).

@isaac-io
Copy link
Contributor

Irrelevant since #25 was reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants