Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamodel classes not generated properly when using hibernate validator with quarkus #368

Closed
iwe-7 opened this issue Aug 25, 2023 · 4 comments
Assignees
Labels
bug Something isn't working
Projects

Comments

@iwe-7
Copy link

iwe-7 commented Aug 25, 2023

Describe the bug
Metamodel classes are not generated properly when using hibernate validator with quarkus.

Expected behavior
Correct generation of $.java metamodel classes

Actual behavior
It seems that the paths of @jakarta.validation.constraints Annotations get mixed into the imports of other classes during metamodel generation:
image

How To Reproduce

  • quarkus project with hibernate panache orm, hibernate validator and jpa streamer
  • create a entity and annotate one of its fields with a jakarta.validation.constraints annotation e.g.:
   @NotBlank
   private String name;
  • try to regenerate jpastreamer metamodel (mvn clean install) -> error should arise in generated classes

Build tool
Maven 3.9.2

JPAStreamer version
JPAStreamer 3.0.2Final

JPA Provider
Quarkus Hibernate Panache 3.2.0.Final

Java Version
Java 17.0.6

@iwe-7 iwe-7 added the bug Something isn't working label Aug 25, 2023
@julgus
Copy link
Member

julgus commented Aug 25, 2023

Thank you for reporting this, I will have a look ASAP!

@julgus
Copy link
Member

julgus commented Aug 29, 2023

I've identified the issue, which should be fixed in the release planned for this week. Thanks again for reporting, it was really helpful.

@julgus julgus added this to the 3.0.4 milestone Aug 29, 2023
@julgus julgus added this to Done in 3.0.4 Aug 29, 2023
@julgus julgus closed this as completed in 4f7edd9 Aug 30, 2023
@julgus
Copy link
Member

julgus commented Aug 31, 2023

Now that the new release is out, would you be able to try the latest Quarkus version 3.0.3.Final to confirm that this has been fixed?

@iwe-7
Copy link
Author

iwe-7 commented Aug 31, 2023

Tested it with Quarkus 3.2.0 and quarkus-jpastreamer 3.0.3.Final and it works!
Thank you for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
3.0.4
Done
Development

No branches or pull requests

2 participants