Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs and feedbacks about skp #1

Open
nflorentin opened this issue Nov 5, 2021 · 0 comments
Open

Bugs and feedbacks about skp #1

nflorentin opened this issue Nov 5, 2021 · 0 comments

Comments

@nflorentin
Copy link

nflorentin commented Nov 5, 2021

Hi Nate,

Thank you for your awesome workshop about sidekiq. I'm learning a lot from it.

I only had a few minors problems:

  • in some files, there is require_relative "../../prof_gray_satellite_analysis" instead of require_relative "../../prof_gray/satellite_analysis"
  • Executing a skp list shows that "Using Less Memory" chapter is the last one before "Epilogue", so skp current (when having progress at Using Less Memory) opens the chapter "Is My App Thread-Safe?", "Using less memory" is associated to the file chapter_7.md, I think there is a few errors with the filenames or indexes of the files

I would sometimes appreciate to have some explanations about the solutions.
In lab 9, for example, I did not find explanation about why inject(:+) is so less performant than inject with a memo in its block. I guess the first one is creating a new string for every iteration and the other is not.
Obviously, it is not big deal, the workshop is still great!

I would like to also thank you for all the very good content on your website, which I'm reading since a few years now.

Have a nice day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant