Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IntelliJ IDEA 2019.3 #829

Closed
bdalenoord opened this issue Nov 29, 2019 · 4 comments · Fixed by #830
Closed

Support IntelliJ IDEA 2019.3 #829

bdalenoord opened this issue Nov 29, 2019 · 4 comments · Fixed by #830

Comments

@bdalenoord
Copy link
Contributor

Issue #821 should add support for IntelliJ IDEA 2019.3, but as it is now publicly available, the plugin no longer works. When reviewing the change for that issue (48d34b2) it dawned upon me that only the Azure pipeline for testing that version was added, not for releasing it...

@bdalenoord
Copy link
Contributor Author

I think the fix would be to add a ij193 block on line https://github.com/spekframework/spek/blob/2.x/azure-pipelines.yml#L140.

@raniejade
Copy link
Member

@bdalenoord you are correct, just the release step is missing. Would you like to send a PR? Otherwise, I'll have time in the weekend do it.

@robstoll
Copy link
Contributor

robstoll commented Dec 3, 2019

Now the only thing missing is a release I guess or is the plugin waiting for approval from Intellij? Anyhow, I still have the Incompatible with the current IntelliJ version

@raniejade
Copy link
Member

@robstoll so the merge will trigger a dev build which gets published to the dev channel (which is waiting for JB's approval). I need to do an actual release (2.0.9) to get the plugin into the stable channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants