Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Docs: Dark Mode #14

Closed
KCarretto opened this issue Mar 8, 2022 · 3 comments
Closed

[feature] Docs: Dark Mode #14

KCarretto opened this issue Mar 8, 2022 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@KCarretto
Copy link
Collaborator

Enable a dark mode toggle in the nav bar for our docs. It should persist the setting, such that subsequent page visits or reloads preserve the user’s choice.

@KCarretto KCarretto added the good first issue Good for newcomers label Mar 8, 2022
@KCarretto KCarretto changed the title Docs: Dark Mode [feature] Docs: Dark Mode Mar 15, 2022
@hulto hulto self-assigned this Sep 11, 2022
@hulto
Copy link
Collaborator

hulto commented Sep 11, 2022

Adding a dark mode button to the existing theme will be hard seems like it will require a JS element to handle the toggle and then building a new style sheet which could be tedious.
If we switch to a just the docs theme (https://just-the-docs.github.io/just-the-docs/docs/configuration/#color-scheme) we can take advantage of the jtd.getTheme() and jtd.setTheme()

image

@hulto
Copy link
Collaborator

hulto commented Sep 13, 2022

Here's a PoC of JTD with a light / dark mode button.
image

image

@hulto hulto linked a pull request Sep 13, 2022 that will close this issue
@hulto
Copy link
Collaborator

hulto commented Nov 26, 2022

Closing for now.
Will reopen if an acceptable approach is found with doxy.

@hulto hulto closed this as completed Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants