Comparator Reference Voltages Incorrect?

[simjman]

I was playing with the comparator reference voltages and couldn't work out why an interrupt wouldn't fire when using vref_2v500, but would when using vref_4v096.

I believe the issue lies here:

DxCore/megaavr/libraries/Comparator/src/Comparator.h

Line 189 in 2a5b6cc

vref_2v500 = 0x02, // 2.5V

and here:

DxCore/megaavr/libraries/Comparator/src/Comparator.h

Line 191 in 2a5b6cc

vref_4v096 = 0x03, // 4.096V

This is from the DA/DB datasheet for reference:

[SpenceKonde]

Yup. I hadn't realized that they changed the order on the Dx/Ex series, I thought it was the same as tiny2 (mTC also gets the identical library).

I belive it was like that since at least 1.3.0, maybe longer, Well over a year. You're the first to notice.

[SpenceKonde]

Fixed now

[simjman]

That's great, glad we caught it!