-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor main script #9
Comments
The |
I'm envisioning creating classes that handle this, something along the lines of Or maybe, to make it more abstract, |
A shell of These should be brought back into |
Plotting has been migrated to it's own repo, so this reduces to cleaning up the main script. That's still a high priority, because we now include it with aospy and feature it heavily in the docs. All of the classes and other machinery should be refactored into the main repo, with the main script itself only importing a minimum of classes and/or functions to enable the user to execute the script. |
Closing, as this is essentially duplicated within the more up-to-date #152 |
Currently there are separate classes to parse the arguments in the main routine for calculations and the main routine for plotting, and lots of methods embedded within plotting classes. The parsing functions within the plotting classes should be refactored out -- the plotting classes shouldn't be responsible for parsing user input, only using the results to generate the desired plots.
There should be a single class if possible, or a single parent class that the others inherit from.
Although it needs refactoring as described above, the functionality of the parsing for plotting is more advanced than for the main calculation routine. The latter just permutes all of the specified inputs, attempting to perform a calculation for every possible combination. The former permits passing arguments to specific panels or plots, or across all elements, among other possibilities (although the syntax is pretty confusing).
The text was updated successfully, but these errors were encountered: