datePublished & dateModified props - why nulls?

[rwasiak]

Hello 👋

great component!

I've found one interesting thing.

react-seo-component/src/seo.tsx

Lines 40 to 45 in d534b8c

	datePublished: datePublished
	? null
	: new Date(Date.now()).toISOString(),
	dateModified: dateModified
	? null
	: new Date(Date.now()).toISOString(),

Why there is a null replacement when datePublished or dateModified is provided? Is there any reason for SEO or it is just an oversight?

[spences10]

Hey @rwasiak, yeah that's my mistake!

Feel free to submit a PR to correct or I can amend myself.

Thanks 🙏

[spences10]

Hey @rwasiak I've just tested this and it works as intended.

The logic is, if there's no date being passed to the component then it will substitute with the current date time.

Closing now, feel free to reopen with any suggestions you think would improve this.

Thanks.

[rwasiak]

Hey @spences10 - it is intended that for passing publishedDate or modifiedDate to SEO component you receive nulls?

Please look at this PR #87

PS - I can't reopen issue closed by someone else 😄