Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Use of Exit Sub outside of "Finally" block #13

Closed
mattpalermo opened this issue Jan 14, 2017 · 0 comments
Closed

Use of Exit Sub outside of "Finally" block #13

mattpalermo opened this issue Jan 14, 2017 · 0 comments

Comments

@mattpalermo
Copy link
Collaborator

The Exit Sub statement has been used outside of the "Finally" block (In this case it is labelled "exitSub") in at least one place in the code. The Exit Sub statement should be replaced by Goto exitSub. The code should be searched through for all uses of Exit and fix this.

The problem with using Exit Sub or Exit Function instead of Goto exitSub is that if in the future someone puts more logic into the exitSub block, they will expect that this will always be called when the procedure exits normally. At the moment there is no logic, so there is currently no functional difference.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant