Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ledfx to Captivate. #6

Closed
wants to merge 13 commits into from
Closed

Conversation

Mattallmighty
Copy link

Hi Spenser,

Created:
File menu dropdown - ability to enter in Ledfx URL
In Light scenes, has a photo/scene + icon. Can click on that to assign a scene.
When you do so, it GETs all Ledfx scenes, and displays in dropdown.
Then user selects a scene they want to activate for that captivate scene.
When you click the captivate light scene, it does a PUT to Ledfx API thus activating the scene in sync with Captivate.
Also checked in auto mode, it works correctly too.

@spensbot
Copy link
Owner

Hey @Mattallmighty,

Great job here! I really appreciate the time it must have taken to adhere to Captivate's existing code structure and tools when working on this LedFX integration.

I also love that the LedFX integration doesn't affect Captivate's UI unless users enable the integration through the file menu. Fantastic!

A couple high level questions/comments before I dig into the code more:

  1. I want to ensure this works with LedFX on mac before merging. I'm trying to build LedFX for my Apple Silicon mac according to these instructions, but I keep getting errors related to "PortAudio.h" not being found. Is there a pre-built version for Apple Silicon that I can use?
  2. I enabled github actions for your PR. It looks like it's failing at the test step, specifically the command: npm exec tsc. If you address those errors it looks like the test will pass!

@Mattallmighty
Copy link
Author

Hey @spensbot,

You're very welcome!
Yeah for sure. Putting it into the users hands if they would like to have the LedFx integration. No interfering with Captivate!

  1. Yeah sure, can you give this a go: https://my.ledfx.app/downloads/ latest and greatest features. I can tell you about the hidden features too on our next chat 😃
  2. Did a few edits and hoping now it will be successful. Would you mind approving to run the workflow again? Fingers crossed 🤞

@spensbot
Copy link
Owner

I'm still having trouble getting LedFX up and running on my mac. Do you know if it's ever been proven to run on Apple Silicon Macs?

The python install at the link you sent worked, but I get this error when I try to run

OSError: cannot load library '/Users/spensersaling/.pyenv/versions/3.10.6/lib/python3.10/site-packages/samplerate/_samplerate_data/libsamplerate.dylib': dlopen(/Users/spensersaling/.pyenv/versions/3.10.6/lib/python3.10/site-packages/samplerate/_samplerate_data/libsamplerate.dylib, 0x0002): tried: '/Users/spensersaling/.pyenv/versions/3.10.6/lib/python3.10/site-packages/samplerate/_samplerate_data/libsamplerate.dylib' (mach-o file, but is an incompatible architecture (have (x86_64), need (arm64e)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants