Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What do users of electrum have to do to take advantage of segwit? #2791

Closed
fresheneesz opened this issue Aug 23, 2017 · 10 comments
Closed

What do users of electrum have to do to take advantage of segwit? #2791

fresheneesz opened this issue Aug 23, 2017 · 10 comments

Comments

@fresheneesz
Copy link

Segwit is coming out tomorrow. I've heard (from here) that wallets must generate P2SH addresses (that start with a '3') in order to use segwit. But all the addresses I see generated in my Electrum start with '1'. Is there anything users have to do to start using segwit? Could something be added to the readme or website to clarify to users what they need to do, if anything, for segwit?

I've checked through a bunch of commits, but nothing makes it clear to me how segwit will be usable:

@SomberNight
Copy link
Member

SomberNight commented Aug 23, 2017

The current release (2.9.3), or the master branch, does not yet have segwit ready to be used on mainnet. It can only be used on testnet at the moment (as evident in the commits you referenced, such as af54ba0).

I believe p2sh-p2wpkh type addresses (the successor of p2pkh, the current '1' type addresses) are fully implemented, but p2sh-p2wsh addresses (which would be needed for e.g. multisig) are not.

Hence, most users will need to wait for a new release of Electrum that at least enabled the currently implemented functionality on mainnet, and then create new "segwit" type wallets (to clarify, this means a wallet with new "seed words", as the current code implies that a wallet having segwit addresses is a property of the seed).

@fresheneesz
Copy link
Author

fresheneesz commented Aug 23, 2017

@SomberNight Thanks for the information! Mind if I add that info to the readme for this project? If that's not the right place for it, where can I add it? Any idea when a version of electrum that supports segwit type wallets might be released?

@ecdsa
Copy link
Member

ecdsa commented Aug 23, 2017

soon

@ecdsa ecdsa closed this as completed Aug 23, 2017
@fresheneesz
Copy link
Author

fresheneesz commented Aug 23, 2017

@ecdsa Cool, but many users (myself included before this thread) are probably assuming Electrum supports Segwit today, since there's been so much time (over a year) to upgrade. I think users should have the info, about how segwit will be dealt with, now (ie regardless of how soon support might happen). How can I help make that happen?

I'm actually surprised p2sh-p2wpkh addresses weren't made the default like a year ago - my understanding is that its been about that long since we've known users will need updated addresses to use Segwit. Had that been done, most people now might not even have had to switch to a new wallet. Electrum is a popular client and getting users on Segwit is important to get people on segwit and lower fees so the community will stop yelling about how they can't buy coffee or whatever.

@SomberNight
Copy link
Member

SomberNight commented Aug 23, 2017

I'm actually surprised p2sh-p2wpkh addresses weren't made the default like a year ago

Coins sent to a p2sh-p2wpkh address, before SegWit activation, are spendable upon presenting the redeemscript without a valid signature. They are only protected by the hash algorithm of p2sh. That is, anyone that can present a script that has RIPEMD160(SHA256(script)) "==" address, can spend from that address. If you tried spending those coins, you would need to reveal the redeemscript, and rational miners would forge their own tx instead of including yours in their block, and steal your coins. This is the basis of all the "anyone-can-spend" "FUD" "segwit-haters" argued for months.

So that is why

p2sh-p2wpkh addresses weren't made the default like a year ago

@fresheneesz
Copy link
Author

fresheneesz commented Aug 23, 2017

Ahh, I didn't know that. Thanks again for the helpful info @SomberNight ! Still wondering how I can help get this information out there : )

@bainsmit
Copy link

Hello,
As a user of Electrum I must confess that I am a little confused. As I own an wallet with addresses starting to 1 (no other is currently possible but that) I am wondering will they be fully functional in the future (I do understand that they will exist but I do not understand how transactions will be concluded between segwit and now segwit addresses. Will it be like for now or not and if many adopts segwit will there be a problem with confirmation of transactions for old addresses, also will receiving and sending be possible with old addresses to new one and vice versa)?.

I do realize that this are noob questions but I can not find too many straight answers...

@fresheneesz
Copy link
Author

@bainsmit Your addresses starting with 1 will remain fully functional in the foreseeable future. You can send between segwit and non-segwit addresses in both directions.

@Engelberg
Copy link

Trezor now supports segwit. If I create a hardware wallet type in Electrum using the Trezor, will Electrum automatically see and support the segwit addresses?

@fresheneesz
Copy link
Author

@Engelberg Its not quite automatic, but not difficult. Here's the guide I used to setup my Trezor through electrum: https://blog.trezor.io/using-trezor-with-electrum-v3-a0b9bcffe26e?gi=96884803f8fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants