Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TREZOR wallets stored in plaintext #2929

Closed
schrectacular opened this issue Sep 25, 2017 · 8 comments
Closed

TREZOR wallets stored in plaintext #2929

schrectacular opened this issue Sep 25, 2017 · 8 comments
Assignees

Comments

@schrectacular
Copy link

TREZOR wallets are stored in plaintext, with no option to encrypt. This means full public keys are exposed, along with address lists.

I would expect that a TREZOR wallet would be stored encrypted unless the TREZOR was connected. Alternatively, a separate Electrum encryption password option.

@lzsaver
Copy link
Contributor

lzsaver commented Sep 26, 2017

Probably the best option is to encrypt such wallets using Trezor itself. This should be an option, because it is convenient to observe the current balance and transactions without a connected device.

@schrectacular
Copy link
Author

schrectacular commented Sep 26, 2017

I believe other wallets have solved this by allowing two import options for hardware wallets:

  • A watch-only wallet for observing transactions, with the option to sign them if the hardware wallet is connected.
  • A "regular" wallet import which is only viewable with the device connected.

Food for thought. Your solution sounds fine as well.

@ecdsa
Copy link
Member

ecdsa commented Oct 7, 2017

it is not possible using the trezor itself; they have disabled message decryption

@ecdsa
Copy link
Member

ecdsa commented Oct 12, 2017

we could encrypt with a password, but it would be unrelated to trezor

@lzsaver
Copy link
Contributor

lzsaver commented Oct 15, 2017

Yes, it does not make sense.

@slush0
Copy link
Contributor

slush0 commented Dec 2, 2017

it is not possible using the trezor itself; they have disabled message decryption

@ecdsa We disabled one particular scheme using elliptic curves, but message encryption is clearly possible with TREZOR. Electrum can use for example CipherKeyValue as described in SLIP 11 (https://github.com/satoshilabs/slips/blob/master/slip-0011.md). We use the same for encrypting transaction labels in our wallet (scheme described in SLIP 15).

@ecdsa
Copy link
Member

ecdsa commented Dec 2, 2017

@SomberNight see slush's comment

@SomberNight SomberNight self-assigned this Dec 3, 2017
@SomberNight
Copy link
Member

This should now be resolved due to #3346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants