Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History "summary" and unconfirmed/local txns #3963

Closed
SomberNight opened this issue Feb 23, 2018 · 2 comments
Closed

History "summary" and unconfirmed/local txns #3963

SomberNight opened this issue Feb 23, 2018 · 2 comments
Labels
Milestone

Comments

@SomberNight
Copy link
Member

h = self.summary
start_date = h.get('start_date')
end_date = h.get('end_date')
if start_date is None or end_date is None:
self.parent.show_message(_("Nothing to summarize."))
return

If there are unconfirmed or local txns in the wallet history, we will not display a summary.

Should we perhaps exclude these transactions from the summary?
What about unverified txns?

Filtering could be done around line 1042:

electrum/lib/wallet.py

Lines 1040 to 1044 in f1b7578

# add summary
if out:
b, v = out[0]['balance'].value, out[0]['value'].value
start_balance = None if b is None or v is None else b - v
end_balance = out[-1]['balance'].value

but then what about "unrealized gains"?

unrealized = self.unrealized_gains(domain, fx.timestamp_rate, fx.ccy)

@SomberNight SomberNight added this to the 3.1 milestone Feb 24, 2018
@ecdsa
Copy link
Member

ecdsa commented Feb 26, 2018

that's a bug, we should display a summary even with unconfirmed tx.
I am still working on that

@ecdsa
Copy link
Member

ecdsa commented Feb 27, 2018

I changed the semantics slightly: start_date and end_date are the dates of the filtered period, and no longer the dates of the first and last transaction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants