Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Entries in Recent Wallet Menu #4020

Closed
jackgbct opened this issue Mar 4, 2018 · 4 comments
Closed

Duplicate Entries in Recent Wallet Menu #4020

jackgbct opened this issue Mar 4, 2018 · 4 comments
Labels

Comments

@jackgbct
Copy link

jackgbct commented Mar 4, 2018

I have been switching between two wallets and in the version (3.0.5) my wallet had duplicate entries in the Recent Wallet Menu such that it edited the config file in the electrum data folder to be:
"recently_open": [
"C:\users\\downloads\electrum_data\wallets\default_wallet",
"C:\Users\
\Downloads\electrum_data\wallets\Default_Wallet",
"C:\Users\\Downloads\electrum_data\wallets\Bech32",
"C:\Users\
\Downloads\electrum_data\wallets\default_wallet"
],

Instead of, as it should be
"recently_open": [
"C:\Users\\Downloads\electrum_data\wallets\Default_Wallet",
"C:\Users\
\Downloads\electrum_data\wallets\Bech32",
},,

I looked through the recent update log and it says nothing about fixing this so I'm not sure if it was fixed or not with the version 3.0.6, though this error took a few weeks to arise so I imagine updating will temporarily fix the error but it will inevitably come back if it wasn't fixed between the two versions.

@SomberNight
Copy link
Member

SomberNight commented Mar 5, 2018

The underlying cause is that we assume paths to be case sensitive.

In Windows, paths are case insensitive.
In general this depends on the file system or maybe the OS, so I am not sure if we should "fix" this.

@jackgbct
Copy link
Author

jackgbct commented Mar 6, 2018

I'm using NTFS filesystems (it's the default). The non case sensitive pathways come from Windows (it's Windows 7 as I hate all the later ones).

It'd be great if it could be fixed though (other than me having to manually edit my config log each time).

Thanks though!

@AbdussamadA
Copy link
Contributor

Slightly related. On linux I have this:

"/home/abdussamad/temp/electrum/testnet/../testnet1",
    "/home/abdussamad/temp/electrum/testnet1"
],

I suggest running it through os.path.abspath first.

@SomberNight
Copy link
Member

fixed in eccb8ec

I suggest running it through os.path.abspath first.

Thanks, indeed, good idea. :)

We are not going to clean existing configs of duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants