Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blockchain.info historical exchange rates #5267

Open
JeremyRand opened this issue Apr 13, 2019 · 3 comments · May be fixed by #5270
Open

Add Blockchain.info historical exchange rates #5267

JeremyRand opened this issue Apr 13, 2019 · 3 comments · May be fixed by #5270

Comments

@JeremyRand
Copy link
Contributor

Blockchain.info provides historical exchange rates, e.g. https://blockchain.info/charts/market-price?timespan=all&daysAverageString=1&format=csv . It would be nice if Electrum supported Blockchain.info as a historical exchange rate provider. (h/t to https://github.com/robertwb/bitcoin-taxes )

@ecdsa
Copy link
Member

ecdsa commented Apr 15, 2019

please write a pull request for that

@JeremyRand
Copy link
Contributor Author

please write a pull request for that

I intend to, if no one beats me to it. :) (Things are super busy here, and this isn't the highest priority for me, but I'll do it at some point.)

@SomberNight
Copy link
Member

SomberNight commented Apr 17, 2019

Note that there is only one data point per 3 days, as opposed to a daily price as with other providers.
Is this fine for e.g. tax purposes?
What does one supposed to do for intermediate days? Use previous data point? Use closest data point? Linearly interpolate?

EDIT: I guess that repo is using the previous (latest that is still older)
https://github.com/robertwb/bitcoin-taxes/blob/9788edad8b11672ab607be9424ae85af8a6145bd/bitcoin_gains.py#L883-L888

@SomberNight SomberNight linked a pull request Apr 17, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants