Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide estimate of fees in fiat, and warn if they are high #6664

Closed
micah opened this issue Oct 18, 2020 · 5 comments
Closed

Provide estimate of fees in fiat, and warn if they are high #6664

micah opened this issue Oct 18, 2020 · 5 comments

Comments

@micah
Copy link

micah commented Oct 18, 2020

When you send coins, the fee estimator is extremely useful. However, it presents things only in btc, and it would be really convenient if it would use the Fiat currency setting to show approximately how much the fee translates to.

The other day I created a transaction, it was pretty small, but it had a lot of inputs. The fee looked reasonable to me, but I misread how many zeros there were after the decimal point, and I nearly sent a transaction with a 220$ fee. Fortunately, I took the fee number and checked it, but if electrum had shown me the fiat conversion, it would have been a lot easier.

Also, it would be really nice if Electrum issued a warning when you were about to send a fee over a certain "reasonable" threshold, to make sure you want to do that. It does ask you to confirm your transaction, but if it says "WARNING: Your fee is abnormally high: 220$! Are you sure you want to send with this fee?"

@SomberNight
Copy link
Member

the fee estimator [...] presents things only in btc, and it would be really convenient if it would use the Fiat currency setting to show approximately how much the fee translates to.
if electrum had shown me the fiat conversion, it would have been a lot easier

Isn't the fee already shown in fiat too?

pic1

Capture

Also, it would be really nice if Electrum issued a warning when you were about to send a fee over a certain "reasonable" threshold, to make sure you want to do that. It does ask you to confirm your transaction, but if it says "WARNING: Your fee is abnormally high: 220$! Are you sure you want to send with this fee?"

There are already two warning conditions:

  • if the fee exceeds 5% of the amount Electrum thinks you are sending

    pic2

    Capture2

  • if the feerate is over 600 sat/byte

    pic3

    Capture3

What new warning condition would you like to see added specifically?

@micah
Copy link
Author

micah commented Oct 18, 2020 via email

@micah
Copy link
Author

micah commented Oct 18, 2020

Here you go, as you can see here in the advanced dialog, it doesn't show me the conversion (although in the basic one it does):

2020-10-18-170003_954x492_scrot

This is approximately 68$ fee.... I think the two warning conditions are nice... but it might be good to be able to configure these in some way in the preferences. For example, I would like to be warned if the fee is ever over $10, even if the fee is less than 5% of what I'm sending.

@mnaei
Copy link

mnaei commented Dec 15, 2020

How does this look? I put $$$$ where the fee estimates in fiat currency would be displayed?

Capture4

@SomberNight
Copy link
Member

#6968 added fiat estimates for amounts and fees in the Advanced tx preview dialog, and
f9f49da ported the missing warning conditions (namely high fee ratio (fee/amount)) to the Advanced tx preview dialog

Example:
Capture

What new warning condition would you like to see added specifically?

[...] This is approximately 68$ fee.... I think the two warning conditions are nice... but it might be good to be able to configure these in some way in the preferences. For example, I would like to be warned if the fee is ever over $10, even if the fee is less than 5% of what I'm sending.

Something like that could be added later; feel free to open another issue specifically asking for that if you feel strongly about it.

I am closing this, as I think the changes made mostly satisfy this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants