electrum/www/pay is not a symlink in the tarball

[sorenstoutner]

In the Git repository electrum/www/pay is a symlink to electrum/www/index.html. However, in the tarball, pay is a separate file with identical contents. When it is not a symlink, trying to access it with a browser causes a download to be initiated instead of displaying the website.

My guess is that some aspect of the packaging of the tarball is converting the symlink into a separate file, but I am unsure at what stage that is happening.

[SomberNight]

hmm I wonder if this explains #7672

[SomberNight]

The tarball is built by setuptools, here:

electrum/contrib/build-linux/sdist/make_sdist.sh

Line 56 in f995a50

TZ=UTC faketime -f '2000-11-11 11:11:11' python3 setup.py --quiet sdist --format=gztar --dist-dir="$PY_DISTDIR"

note the setuptools is the successor of distutils (used to be in stdlib), for which this was reported as a bug at one point:
https://bugs.python.org/issue12585

[sorenstoutner]

FYI, I have deleted the duplicate file and added the symlink in the upcoming 4.3.3 Debian package. Let me know when this is fixed in the tarball generation.