Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qml: change "receive flow": prompt for amount/description before creating request #8258

Closed
SomberNight opened this issue Mar 17, 2023 · 3 comments
Assignees
Labels

Comments

@SomberNight
Copy link
Member

related to discussion in #8254

I propose:

  1. clicking the "Receive" button opens the "Edit payment request" popup, except it would be named ~"Create payment request", while still on the history screen (in the background)
    • the user can then enter an amount/description/expiration here
      • if the user cancels the popup, a payment request is not created, and they are back in the history screen
      • if the user clicks "Apply" (maybe renamed to ok/create), the payment request is created and saved, and the "Receive" screen opens
  2. in the Receive screen, I think there would be no more need for the "Edit" button/functionality - once a request is created, no need to allow changing it
  3. for expiration time, there should not be a "never" option
    • this would make hitting the gap limit less likely, as we reuse addresses for expired requests
  4. still open question: what to do if the gap limit is hit anyway? maybe it is sufficient to show the existing "warning/create_anyway" popup...
@SomberNight SomberNight changed the title qml: change "receive flow" qml: change "receive flow": prompt for amount/description before creating request Mar 17, 2023
@ecdsa ecdsa self-assigned this Mar 17, 2023
@ecdsa
Copy link
Member

ecdsa commented Mar 17, 2023

Regarding 4 (what to do if the gap limit is hit), see #8254

@SomberNight
Copy link
Member Author

note: Thomas has some work-in-progress code for this

@ecdsa ecdsa closed this as completed in fed5fe5 Mar 17, 2023
@accumulator
Copy link
Member

This is much better actually 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants