Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2023-39910: Milk Sad #8570

Closed
ZioberMichal opened this issue Aug 9, 2023 · 1 comment
Closed

CVE-2023-39910: Milk Sad #8570

ZioberMichal opened this issue Aug 9, 2023 · 1 comment

Comments

@ZioberMichal
Copy link

Hey,
is it a chance that Electrum is vulnerable because of the CVE-2023-39910?

See also: milksad.info

Regards
Michał

@SomberNight
Copy link
Member

Hi. Nice write-up.

Electrum uses the secrets module from the python standard library as source of entropy. Before that, os.urandom was used directly. Both are considered cryptographically secure.

The interesting code starts here:

def make_seed(self, *, seed_type=None, num_bits=None) -> str:

So, no, this issue should not affect Electrum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants