How to avoid global variables?

[frederikhors]

Using code like this:

  var cmdPrint = &cobra.Command{
    Use:   "print [string to print]",
    Short: "Print anything to the screen",
    Args: cobra.MinimumNArgs(1),
    Run: func(cmd *cobra.Command, args []string) {
      fmt.Println("Print: " + strings.Join(args, " "))
    },
  }
``

I get this error from golangci-lint:

cmdPrint is a global variable (gochecknoglobals)

Is there a way to satisfy the linter and to write a batter code?

[frederikhors]

I opened leighmcculloch/gochecknoglobals#17.

[quasilyte]

You can make it local by moving it to a function where you're using it.
(leighmcculloch/gochecknoglobals#17 (comment) recommends the same.)

This example from the README:

var rootCmd = &cobra.Command{
  Use:   "hugo",
  Short: "Hugo is a very fast static site generator",
  Long: `A Fast and Flexible Static Site Generator built with
                love by spf13 and friends in Go.
                Complete documentation is available at http://hugo.spf13.com`,
  Run: func(cmd *cobra.Command, args []string) {
    // Do Stuff Here
  },
}

func Execute() {
  if err := rootCmd.Execute(); err != nil {
    fmt.Fprintln(os.Stderr, err)
    os.Exit(1)
  }
}

Can be rewritten like this:

func Execute() {
  rootCmd := &cobra.Command{
    Use:   "hugo",
    Short: "Hugo is a very fast static site generator",
    Long: `A Fast and Flexible Static Site Generator built with
                  love by spf13 and friends in Go.
                  Complete documentation is available at http://hugo.spf13.com`,
    Run: func(cmd *cobra.Command, args []string) {
      // Do Stuff Here
    },
  }
  if err := rootCmd.Execute(); err != nil {
    fmt.Fprintln(os.Stderr, err)
    os.Exit(1)
  }
}

[MichaelMure]

This is what I came up with: https://github.com/MichaelMure/git-bug/tree/master/commands
Bonus point for testability.

[github-actions]

This issue is being marked as stale due to a long period of inactivity

[frederikhors]

Nope

[johnSchnake]

Options given here already and other tickets discuss the same issue (e.g. #1599). Closing motivated by #1600