Zsh completion never suggests files but only options

[corneliusweig]

An overhauled zsh completion was merged with #646. One drawback of that script is that it only ever suggests options. Say for example, I have a command cmd with option --foo. When I type

cmd <Tab><Tab>

I would expect to see a suggestion list of all files in the working dir. However, it actually adds a - and shows the --foo suggestion.

It would be much better to trigger option completion only when typing

cmd -<Tab><Tab>  # <-- note the dash

and otherwise show the standard list of files in the cwd.

/cc @rsteube @babysnakes

[rsteube]

Since you added a specific completion for cmd you have overriden the default _files function.
Now unless you tell it that your command accept files it won't complete it for you.

command.MarkZshCompPositionalArgumentFile(1) might be the solution (complete files for first argument).

There's also the possibilty filtering by patterns:
https://github.com/spf13/cobra/blob/master/zsh_completions.go#L125

[corneliusweig]

Thanks @rsteube, I was not aware that this had to be enabled manually. 👍

[blacktop]

@rsteube can you show a small example on how to add them? I am trying and it doesn't seem to work for sub commands?

[rsteube]

There is a test using it:

cobra/zsh_completions_test.go

Line 164 in e2c45ac

r.MarkZshCompPositionalArgumentFile(1, "*.log")

You probably know, but if it's a sub command it needs to be called on the sub command and not on the root command. Can't think of any other reason right now why it's not working.

[blacktop]

I added it here:

https://github.com/blacktop/ipsw/blob/9b307d745c4a7b27f8567d281c0fa7ce0169c600/cmd/ipsw/cmd/device.go#L49

It doesn't seem to have any impact on what is output by running:

ipsw completion zsh

I would have expected to see "DeviceTree*" show up somewhere or _file

😕

[rsteube]

I think it's because of the sub sub command "list": https://github.com/blacktop/ipsw/blob/9b307d745c4a7b27f8567d281c0fa7ce0169c600/cmd/ipsw/cmd/device_list.go#L15

That should set the list commond as positional argument 1 and thus override your file argument (both is probably not possible). When that is commented the Devicetree argument is rendered in the output.

[blacktop]

Ah thank you! I should simplify my sub sub subs into a more typical cli. I also confirmed if I remove the sub subs it does in fact work 👍