Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any graceful restart? #994

Closed
ninorain22 opened this issue Nov 21, 2019 · 3 comments
Closed

Any graceful restart? #994

ninorain22 opened this issue Nov 21, 2019 · 3 comments

Comments

@ninorain22
Copy link

ninorain22 commented Nov 21, 2019

I deploy my daemon program in k8s, what can I do to graceful stop or restart?

@jharshman
Copy link
Collaborator

@ninorain22 this doesn't seem like it's related to this project.

@pacoxu
Copy link

pacoxu commented Jun 4, 2020

@ninorain22 this doesn't seem like it's related to this project.

Actually, most of kubernetes system components like kube-scheduler (https://github.com/kubernetes/kubernetes/blob/release-1.18/cmd/kube-scheduler/app/server.go#L70) use cobra to run commands.

In some case, the component configuration will change and reload/restart(when config changes) is a basic feature.

@jharshman
Copy link
Collaborator

Still not related to this project. Cobra does not handle configuration, only runtime flags. It does however integrate well with https://github.com/spf13/viper which does handle hot reloads.

https://github.com/spf13/viper#watching-and-re-reading-config-files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants