Durations don't work in viper.Marshal

[kelvl]

Hi, I am unable to Marshal (or Unmarshal) Duration fields whereas, GetDuration("fieldName") works

I've attached an simple test case

package main

import (
    "bytes"
    "testing"
    "time"

    "github.com/spf13/viper"
)

func TestDurationConfig(t *testing.T) {
    type DurationConfig struct {
        testduration time.Duration
    }

    var testYaml = []byte(`
               TestDuration: 5ms
        `)

    viper.SetConfigType("yaml")

    viper.ReadConfig(bytes.NewBuffer(testYaml))

    t.Logf("All keys: %#v", viper.AllSettings())

        // this works
    if viper.GetDuration("testduration") != 5*time.Millisecond {
        t.Errorf("Duration is not 5ms - %v", viper.GetDuration("testduration"))
    }

    var config = &DurationConfig{}

    viper.Marshal(config)

        // this doesn't
    if config == nil || config.testduration != 5*time.Millisecond {
        t.Errorf("Duration config is not 5ms - %#v", config)
    }
}

[emilevauge]

Any chance to get this bug corrected?

[ondrajz]

+1

[yauhen-l]

I've suggested fix: #205