Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BindStruct together with mapstructures remain #1798

Open
3 tasks done
florianrusch opened this issue Apr 2, 2024 · 2 comments
Open
3 tasks done

BindStruct together with mapstructures remain #1798

florianrusch opened this issue Apr 2, 2024 · 2 comments
Labels
kind/bug Something isn't working

Comments

@florianrusch
Copy link

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I am not looking for support or already pursued the available support channels without success.
  • I have checked the troubleshooting guide for my problem, without success.

Viper Version

1.18.2

Go Version

1.22

Config Source

Environment variables, Files

Format

YAML

Repl.it link

No response

Code reproducing the issue

package main

import (
	"github.com/spf13/viper"
	"log"
	"os"
	"strings"
)

type config struct {
	others any `mapstructure:",remain"`
}

func main() {
	_ = os.Setenv("CONFIG_FOOBAR", "some-value")

	var foundconfig config
	viper.AutomaticEnv()
	viper.SetEnvKeyReplacer(strings.NewReplacer(".", "_"))
	err := viper.Unmarshal(&foundconfig)
	if err != nil {
		return 
	}

	log.Println(foundconfig)
}

Expected Behavior

I would expect, that foundconfig.others is containing map[string]any{"foobar": "some-value"}

Actual Behavior

foundconfig is empty

Steps To Reproduce

No response

Additional Information

No response

@florianrusch florianrusch added the kind/bug Something isn't working label Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

👋 Thanks for reporting!

A maintainer will take a look at your issue shortly. 👀

In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues.

⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9

📣 If you've already given us your feedback, you can still help by spreading the news,
either by sharing the above link or telling people about this on Twitter:

https://twitter.com/sagikazarmark/status/1306904078967074816

Thank you! ❤️

@sagikazarmark
Copy link
Collaborator

Unfortunately, this isn't how AutomaticEnv works. At the moment, it needs something to map environment variables against. The new bind struct feature would still only work with structs that have matching keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants