Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider whether to use proper globbing in Cell files() #306

Open
fatcerberus opened this issue Nov 16, 2019 · 0 comments
Open

Consider whether to use proper globbing in Cell files() #306

fatcerberus opened this issue Nov 16, 2019 · 0 comments

Comments

@fatcerberus
Copy link
Member

fatcerberus commented Nov 16, 2019

files() currently uses a very rudimentary globbing implementation wherein only the final portion of the given pattern can contain wildcards. Any directory information in the pattern is used verbatim. With the introduction of FS.match(), there is now a much more powerful pattern matcher built in which can support, e.g. globstars (**) and bracket notation. Consider using that for files() as well.

This is technically a breaking change, but the existing pattern structure is so simple that most existing Cellscripts shouldn't be affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant