chore: update deps #269
chore: update deps #269
Conversation
| "istanbul": "0.3.x", | ||
| "jasmine-node": "1.14.5", | ||
| "istanbul": "^0.4.5", | ||
| "jasmine-node": "github:daern91/jasmine-node", |
There was a problem hiding this comment.
jasmine-node has one critical dependency and has not yet updated it due to it becoming a breaking change and not supporting node v4. More reading here: mhevery/jasmine-node#421
Therefore, I forked and upgraded it since we only support Node >= 6 anyways.
|
Hmm, very strange. It worked on the first run with |
daern91
force-pushed
the
update-deps
branch
2 times, most recently
from
646b7c7
to
9135446
Compare
| "grunt-cli": "^1.2.0", | ||
| "grunt-coffeelint": "0.0.13", | ||
| "grunt-contrib-clean": "0.6.0", | ||
| "grunt-contrib-coffee": "0.13.x", | ||
| "grunt-contrib-coffee": "github:daern91/grunt-contrib-coffee", |
There was a problem hiding this comment.
Changing this one to forked version with updated dependencies. Reason for this is that v1.0.0 works for us but has one warning. In addition, v2.x.x fixed this but also upgraded to use CoffeeScript v2 which introduced a lot of breaking changes
This did not work out for us and made all tests fail
| '#\n' + | ||
| '# <%= _.pluck(pkg.licenses, \"url\").join(\"\\n\") %>\n' + | ||
| '# <%= _.map(pkg.licenses, \"url\").join(\"\\n\") %>\n' + |
There was a problem hiding this comment.
underscore dropped support for _.pluck() since it had the same functionality as _.map()
| "sphere-coffeelint": "git://github.com/sphereio/sphere-coffeelint.git#master", | ||
| "underscore": "1.8.x", | ||
| "underscore-mixins": "0.1.x", |
There was a problem hiding this comment.
duplicate, already inside dependencies as found by @Freyert
|
I think the next step will be to pull this into the |
|
Good idea, I've started a wip PR in most of them and will finish tomorrow. |
npm auditreturns 43 vulnerabilities (16 low, 6 moderate, 20 high, 1 critical)PR updates them all so we have 0, please see more in comments below
resolves #270
resolves #266