Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method to get version number #302

Merged
merged 6 commits into from
Aug 5, 2019
Merged

Conversation

sebbsan
Copy link
Contributor

@sebbsan sebbsan commented Jul 26, 2019

Summary

added method that returns the version of this SDK

Description

This was necessary to remove dependency in sphere-node-utils to an unmaintained library that introduces vulnerabilities

Todo

  • Tests
    • [x ] Unit
    • [x ] Integration
    • [x ] Acceptance
  • Documentation

src/coffee/utils.coffee Outdated Show resolved Hide resolved
@LEQADA
Copy link
Contributor

LEQADA commented Jul 26, 2019

@sebbsan do I understand correct that you want to remove some of the dependencies of sphere-node-sdk in the sphere-node-utils if version of the first one is lower than some N?

@sebbsan
Copy link
Contributor Author

sebbsan commented Jul 26, 2019

@LEQADA the problem is this code here which I want to replace with this API method:
https://github.com/sphereio/sphere-node-utils/blob/e39b07a188b081346b348bcf31ab95349e300ce4/src/coffee/helpers/user-agent.coffee#L6

the dependency load-module-pkg introduces a vulnerability + hasn't been maintained for 2 years.
So once we release a new version of this, I can make a new version of sphere-node-utils

@daern91
Copy link
Contributor

daern91 commented Jul 26, 2019

Thanks a lot for the PR. I first didn't understand why we needed this but after reading your response to @LEQADA I think it makes sense.

@coveralls
Copy link

coveralls commented Jul 26, 2019

Coverage Status

Coverage increased (+0.003%) to 97.669% when pulling d4588d1 on AddMethodToReturnVersion#301 into f8d8c13 on master.

src/spec/utils.spec.coffee Outdated Show resolved Hide resolved
@sebbsan
Copy link
Contributor Author

sebbsan commented Jul 26, 2019

@LEQADA @daern91 and after we have a new version of sphere-node-utils we need a new version of this one again. There is a circular dependency..

@daern91 daern91 changed the title Add method to return version#301 feat: add method to get version number Jul 26, 2019
@daern91 daern91 merged commit 001a038 into master Aug 5, 2019
@daern91 daern91 deleted the AddMethodToReturnVersion#301 branch August 5, 2019 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants