Allow to process search results. Refs #75. #76
Conversation
| @@ -250,7 +250,6 @@ class ProductProjectionService extends BaseService | |||
| # .search() | |||
| search: -> | |||
| @_currentEndpoint = '/product-projections/search' | |||
| @fetch() | |||
There was a problem hiding this comment.
I don't like it, it's a breaking change. We should think of something else.
There was a problem hiding this comment.
It's a matter of documentation ;)
See #75
There was a problem hiding this comment.
Actually it should work https://github.com/sphereio/sphere-node-sdk/blob/master/src/coffee/services/base.coffee#L329
Let me have a look.
There was a problem hiding this comment.
Sorry, the endpoint is set on the fly...let me have another look then ;)
There was a problem hiding this comment.
I guess the painless solution would be to have a new method called processSearch. Any other solution would be a breaking change I guess.
What do you think?
There was a problem hiding this comment.
Hmm ok, well just for search then, so using forSearch.
There was a problem hiding this comment.
You're using the service for search. Or asSearch.
|
Will adapt to |
|
@emmenko please check again. |
| # .asSearch() | ||
| # .process(...) | ||
| asSearch: -> | ||
| @_currentEndpoint = '/product-projections/search' |
|
Add a test and squash your commits then before merging, thanks |
Allow to process search results. Refs #75.
@emmenko please review