feat(process): add cli parameters for importing directly to sphere #40
Conversation
|
Integration tests don't work because of missing sphere.io credentials in travis env variables. |
1 similar comment
| config = | ||
| sphereClientConfig: options | ||
|
|
||
| Promise.resolve config |
There was a problem hiding this comment.
No need for Promise.resolve. You can just return config here since you are already in the then callback.
Also in line 49
|
@junajan can you fix the breaking test also? Would be awesome 😊 |
1 similar comment
| @@ -1,28 +1,32 @@ | |||
| language: node_js | |||
| node_js: | |||
| - '0.10' | |||
| - '0.12' | |||
| - '0.10' | |||
There was a problem hiding this comment.
I think we can get rid of this. And we should test on 4 as well
| sphereClient.productTypes.byId(productType.id) | ||
| .delete(productType.version) | ||
| .then -> | ||
| done() |
There was a problem hiding this comment.
Nitpick: you can keep the chain as a flat structure
importer.init(argv)
.then -> sphereClient.productTypes.fetch()
.then (res) ->
console.log "Deleting old product types", res.body.results.length
Promise.map res.body.results, (productType) ->
sphereClient.productTypes.byId(productType.id)
.delete(productType.version)
.then doneThere was a problem hiding this comment.
updated here 48a32c2
| importer = null | ||
| sphereClient = null | ||
|
|
||
| before -> |
There was a problem hiding this comment.
You're doing async stuff here, you have to use the done callback.
There was a problem hiding this comment.
I switched tests to mocha which is working with Promises too - so it uses promise instead of done callback
| silent: !! argv.logSilent | ||
| streams: [ | ||
| { level: 'error', stream: process.stderr } | ||
| { level: argv.logLevel || 'info', path: "#{argv.logDir || '.'}/#{package_json.name}.log" } |
There was a problem hiding this comment.
It might be better to use path.join here
|
OK LGTM now 👍 |
No description provided.