-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
55 fix tests upgrade dependencies #56
Conversation
Changes Unknown when pulling f0b340e on 55-fix-tests-upgrade-dependencies into ** on master**. |
src/spec/helper/helper.coffee
Outdated
@@ -41,3 +41,30 @@ exports.createReader = (fileType, delimiter = ',', encoding = 'utf-8' ) -> | |||
csvDelimiter: delimiter, | |||
encoding: encoding, | |||
importFormat: fileType, | |||
|
|||
exports.unpublishAllProducts = (client) -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to export this function as it's not used anywhere else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sphereClient.productTypes.byId(productType.id) | ||
.delete(productType.version) | ||
, concurrency: 10 | ||
Helper.deleteAllProducts sphereClient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could also move this function to the helper file so you export only this one and it calls the others implicitly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just a few nitpicks
Changes Unknown when pulling fa6e1da on 55-fix-tests-upgrade-dependencies into ** on master**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good...
Summary
Resolves #55