Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(generator): Support importing of productType.key #52 #59

Merged
merged 8 commits into from
Feb 27, 2018
Merged

feat(generator): Support importing of productType.key #52 #59

merged 8 commits into from
Feb 27, 2018

Conversation

junajan
Copy link
Contributor

@junajan junajan commented Feb 23, 2018 •
edited

Summary

Support importing of productType.key (and log error and skip PT if the key is not provided)
Resolves #52

Todo

  • Tests
    • Unit
    • Integration
    • Acceptance
  • Documentation

@junajan junajan self-assigned this Feb 23, 2018
@junajan junajan requested a review from wizzy25 February 23, 2018 10:27
@coveralls
Copy link

coveralls commented Feb 23, 2018 •
edited

Coverage Status

Coverage increased (+0.04%) to 90.076% when pulling 4ac947e on 52-import-product-type-keys into cd38028 on master.

@wizzy25
Copy link
Contributor

wizzy25 commented Feb 27, 2018

I think this is good enough for a merge 💯

@junajan junajan merged commit 7a4cc70 into master Feb 27, 2018
@junajan junajan deleted the 52-import-product-type-keys branch February 27, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wizzy25 wizzy25 wizzy25 approved these changes

Assignees

@junajan junajan

Labels
Type: Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@junajan @coveralls @wizzy25