Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OIDC4VCI is not passing endpointOpts.getCrendentialOfferOpts #73

Closed
ragnika opened this issue Oct 23, 2023 · 2 comments
Closed

OIDC4VCI is not passing endpointOpts.getCrendentialOfferOpts #73

ragnika opened this issue Oct 23, 2023 · 2 comments

Comments

@ragnika
Copy link

ragnika commented Oct 23, 2023

OID4VCI/packages/issuer-rest/lib/OID4VCIServer.ts

Line 114 in e530d55

getCredentialOfferEndpoint(this.router, this.issuer, opts?.getCredentialOfferOpts)

opts?.getCredentialOfferOpts is passed instead of opts?.endpointOpts.getCredentialOfferOpts
@ragnika
Copy link
Author

ragnika commented Oct 23, 2023

opened a small PR to fix this
#74

@nklomp
Copy link
Contributor

nklomp commented Nov 23, 2023

Sorry for the late reply and thanks for the fix 👍

@nklomp nklomp closed this as completed Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ragnika @nklomp