Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option 🏷️ #6

Open
Paebbels opened this issue Jan 9, 2020 · 5 comments
Open

New option 🏷️ #6

Paebbels opened this issue Jan 9, 2020 · 5 comments
Labels

Comments

@Paebbels
Copy link

Paebbels commented Jan 9, 2020

Please add a new option :label:, that adds a labels to all the created reST output:

 if is_program:
   yield '.. program:: ' + title
   yield ''

+ if 'label' in self.options:
+   yield ''
+   yield '.. _%s:' % (self.options.get('label') + title).replace(" ", "-")

 yield title
 yield ('!' if is_subgroup else '?') * len(title)
 yield ''
@Paebbels
Copy link
Author

@langston-barrett any thoughts on this change?

@langston-barrett
Copy link
Collaborator

@Paebbels Seems fine to me, please re-open your PR whenever you're ready to add it.

@Paebbels
Copy link
Author

OK.

@Paebbels
Copy link
Author

Paebbels commented Mar 8, 2023

@langston-barrett I have now some time and I would like to re-open the PR.

While checking what was changed in the last year/months, I still see a lot of inefficient and bad Python code.

If you like, you can get a full code review and then decide what to enhanced and when to do it.

@langston-barrett
Copy link
Collaborator

@Paebbels Feel free to open PRs or open issues with any suggested improvements or new features!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants