Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DejaVu Sans Mono specified incorrectly #141

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Lahvuun
Copy link
Contributor

@Lahvuun Lahvuun commented Aug 29, 2018

The space in the font's name causes both Chrome and Firefox to fail at recognizing the font, so they then fall back to monospace (in my case Liberation Mono).

Here's the difference in Chrome:
font1
font2

I only tested this on Gentoo Linux, the behavior may be different on other platforms. The font's actual name is DejaVu Sans Mono, though.

@bitprophet
Copy link
Collaborator

Thanks for the report! Weird, thought that change came from a manually tested patch but clearly somebody in the pipeline (me?!?!) didn't test it strongly enough.

Though now I'm wondering whether this font is named differently on different platforms (as you suggest), which would imply we want to stick both variants in here...I'll test on my end real quick.

@bitprophet
Copy link
Collaborator

Ah, I may be thinking of the regular font family, the code font family has probably been unchanged for some time (not sure that makes this any better...).

Also its current value starting with Consolas and Menlo explains why I and many others would never have hit this, as modern versions of macOS contain one or both of those and never get to seeking Deja Vu.

@bitprophet
Copy link
Collaborator

OK, my (macOS 10.12 Sierra) system has no Deja anything whatsoever, so I can't natively test this.

However a quick Google confirms your assertion that there's no space, so I'm happy to consider this a straight up typo. Thanks!

@bitprophet bitprophet merged commit 5f996c0 into sphinx-doc:master Sep 6, 2018
bitprophet added a commit that referenced this pull request Sep 6, 2018
@Lahvuun Lahvuun deleted the font-dejavu-fix branch September 7, 2018 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants