Skip to content
This repository has been archived by the owner on Nov 8, 2020. It is now read-only.

@with_app decorator should return the value of the decorated function #12

Closed
jnikula opened this issue Jan 24, 2019 · 1 comment
Closed

@with_app decorator should return the value of the decorated function #12

jnikula opened this issue Jan 24, 2019 · 1 comment
Labels
enhancement

Comments

@jnikula
Copy link
Contributor

jnikula commented Jan 24, 2019

Seems to me you can't use @with_app to decorate a function that should return a value, because the decorator doesn't return the value of the func passed in. A simple test seems to confirm this.

https://github.com/sphinx-doc/sphinx-testing/blob/master/src/sphinx_testing/util.py#L162
@tk0miya
Copy link
Member

tk0miya commented Jan 26, 2019

+1; Reasonable.
Could you send us a pull request please?

@jnikula jnikula mentioned this issue Jan 26, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tk0miya @jnikula